Support managing source component in the UI #1624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
csordasmarton
commented
Jun 5, 2018
csordasmarton
commented
csordasmarton
force-pushed
the
ui-component-management
branch
from
ccbf9b1 to
68942e6
Compare
gyorb
suggested changes
Jul 26, 2018
| this._componentValue = new SimpleTextarea({ | ||
| class : 'component-value', | ||
| rows : 10, | ||
| placeholder : 'Value of the source component. Each line must start ' |
There was a problem hiding this comment.
I would recommend a small rephrasing in the placeholder:
with a "+" (results from this path should be listed) or "-" (results from this path should not be listed) sign. E.g.: '+/a/b/x.cpp or -/a/b/'
I would do this rephrasing in the command line and in the user guide too.
csordasmarton
force-pushed
the
ui-component-management
branch
from
cac1335 to
699828f
Compare
gyorb
suggested changes
Jul 31, 2018
csordasmarton
force-pushed
the
ui-component-management
branch
from
699828f to
a1e7217
Compare
gyorb
approved these changes
Aug 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.