Allow comparison of two report directories #1635
Conversation
csordasmarton
added
enhancement 🌟
CLI 💻
| for res in baseline_dir_results: | ||
| if res.report_hash not in new_hashes: | ||
| filtered_reports.append(res) | ||
| print(base_hashes) |
There was a problem hiding this comment.
I think these prints were left from debugging.
csordasmarton
force-pushed
the
compare-report-directories
branch
from
3bd65be to
9fd7d97
Compare
csordasmarton
force-pushed
the
compare-report-directories
branch
from
9fd7d97 to
355de6d
Compare
There was a problem hiding this comment.
It would be nice to print out the whole path or product url and run name at the end of the comparison output. So the user can see what was compared.
If there is a local report directory with the same name as a run the local directory will be used for comparison and not the remote run at the server.
csordasmarton
force-pushed
the
compare-report-directories
branch
2 times, most recently
from
533aa6d to
b139ca6
Compare
|
@gyorb Done. I have also refactored the code a little bit. Now we are handling cases when basename parameter is a report directory and newname is a remote run. I have also added test cases to this. |
csordasmarton
force-pushed
the
compare-report-directories
branch
from
b139ca6 to
a574a2c
Compare
csordasmarton
force-pushed
the
compare-report-directories
branch
from
a574a2c to
249ae60
Compare
csordasmarton
force-pushed
the
compare-report-directories
branch
from
249ae60 to
c1167dd
Compare
csordasmarton
force-pushed
the
compare-report-directories
branch
from
c1167dd to
f12a4c1
Compare
| args.basename, | ||
| os.path.abspath(args.newname)) | ||
| print_diff_results(reports) | ||
| LOG.info("Compared remote run %s and local report directory %s", |
There was a problem hiding this comment.
remote run can be multiple runs if a user gave a wildcard pattern like run*, the printed text should reflect that.
The same issue applies to other places where run names are used for comparison.
It could help if we would print out the matching run names in these cases.
* It is possible to compare two report directory. * Handle cases when basename is a report directory and newname is a remote run. * Filter the results of local comparison. * Test cases for local comparison.
csordasmarton
force-pushed
the
compare-report-directories
branch
from
f12a4c1 to
3eb925f
Compare
No description provided.