If the json file is incorrect formatted, show the impacted file #1665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if i['pid'] not in append_pids and | ||
| (i['hostname'] + ":" + str(i['pid'])) not in remove and | ||
| __checkInstance(i['hostname'], i['pid'])] | ||
| try: |
There was a problem hiding this comment.
We have a function in our util to handle invalid json files:
codechecker/libcodechecker/util.py
Line 552 in 2630549
It would be better to use this.
There was a problem hiding this comment.
@sylvestre Do you plan to update this pull request? If yes please fix pycodestyle error:
libcodechecker/server/instance_manager.py:79:80: E501 line too long (80 > 79 characters)
Note: I have created a separate pull request (#1695) to handle invalid json files properly in all places. So if you fix the style error we will accept this pull request.
|
This problem has already been solved in #1695. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.