Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restructure python requirements files #1689

Merged
merged 1 commit into from
Jul 30, 2018
Merged

Conversation

gyorb
Copy link
Contributor

@gyorb gyorb commented Jul 27, 2018

GitHub can automatically detect vulnerabilities in
3pp dependecies if the requirements files follow
the naming conventions

GitHub can automatically detect vulnerabilities in
3pp dependecies if the requirements files follow
the naming conventions
@gyorb gyorb added the dev env ⛑️ Development environment label Jul 27, 2018
@gyorb gyorb added this to the release 6.8 milestone Jul 27, 2018
@whisperity
Copy link
Contributor

Generally looks good. Can you test it on a dummy repository where you push these to master (or on your own fork, even... if dependency checks work for forks.)?

My only concern is, shouldn't these files go under the vendor directory, in any case? The naming of the top-level folder feels weird.

@gyorb
Copy link
Contributor Author

gyorb commented Jul 30, 2018

I've tested it on my fork and GitHub detects the files correctly. requirements.txt is kept usually top level but because we have multiple files for different purposes I though we should keep at least the directory top level.

@csordasmarton csordasmarton merged commit 57d4620 into Ericsson:master Jul 30, 2018
@gyorb gyorb deleted the deps branch April 11, 2019 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev env ⛑️ Development environment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants