Upload analyzer statistics information #1721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
csordasmarton
commented
Aug 28, 2018
csordasmarton
commented
csordasmarton
added
enhancement 🌟
API change 📄
csordasmarton
force-pushed
the
upload-report-directory
branch
from
cea1df4 to
f673918
Compare
csordasmarton
force-pushed
the
upload-report-directory
branch
from
f673918 to
3abbaf8
Compare
whisperity
reviewed
Sep 4, 2018
api/v6/report_server.thrift
Outdated
| @@ -72,6 +72,10 @@ enum SortType { | |||
| BUG_PATH_LENGTH, | |||
| } | |||
|
|
|||
| enum StoreFileSizeLimit { | |||
| FAILURE_ZIP_SIZE, # Maximum size of the collected failed zips which can be store on the server. | |||
There was a problem hiding this comment.
I would rename this enum to be StoreLimitKind or something like that, to explain that the enumconstants by themselves don't contain limits. Also, # is used for comment instead of //.
csordasmarton
force-pushed
the
upload-report-directory
branch
from
3abbaf8 to
d6ed438
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.