Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[report-converter] Support Markdownlint #2829

Merged
merged 1 commit into from
Aug 31, 2020
Merged

[report-converter] Support Markdownlint #2829

merged 1 commit into from
Aug 31, 2020

Conversation

csordasmarton
Copy link
Contributor

No description provided.

@csordasmarton csordasmarton added enhancement 🌟 test ☑️ Adding or refactoring tests documentation 📖 Changes to documentation. tools 🛠️ Meta-tag for all the additional tools supplied with CodeChecker: plist2html, tu_collector, etc. labels Jul 10, 2020
@csordasmarton csordasmarton added this to the release 6.14.0 milestone Jul 10, 2020
@csordasmarton csordasmarton requested review from gyorb and bruntib July 10, 2020 11:15
@csordasmarton csordasmarton requested a review from dkrupp as a code owner July 10, 2020 11:15
@csordasmarton csordasmarton force-pushed the markdownlint_support branch 2 times, most recently from 758307e to 291f90a Compare August 24, 2020 13:19
@csordasmarton csordasmarton requested a review from bruntib August 24, 2020 13:19
gyorb
gyorb previously requested changes Aug 24, 2020
View reviewed changes
Copy link
Contributor

@gyorb gyorb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an extra dot in the store file paths:
~/codechecker/docs**/.**/usage.md

I think it gets there during the report conversion because the parse command prints out that extra dot too in the filepath.

tools/report-converter/README.md Outdated Show resolved Hide resolved
tools/report-converter/README.md Outdated Show resolved Hide resolved
tools/report-converter/README.md Outdated Show resolved Hide resolved
tools/report-converter/README.md Outdated Show resolved Hide resolved
tools/report-converter/codechecker_report_converter/markdownlint/analyzer_result.py Outdated Show resolved Hide resolved
tools/report-converter/tests/unit/mdlint_output_test_files/Makefile Outdated Show resolved Hide resolved
@csordasmarton csordasmarton requested a review from gyorb August 25, 2020 07:02
@gyorb
Copy link
Contributor

gyorb commented Aug 25, 2020

Codacy Here is an overview of what got changed by this pull request:

Issues
======
- Added 1
           

Complexity increasing per file
==============================
- tools/report-converter/tests/unit/test_mdl_parser.py  3
- tools/report-converter/codechecker_report_converter/markdownlint/analyzer_result.py  2
- tools/report-converter/codechecker_report_converter/markdownlint/output_parser.py  3
         

Clones added
============
- tools/report-converter/tests/unit/test_mdl_parser.py  2

See the complete overview on Codacy

@csordasmarton csordasmarton dismissed gyorb’s stale review August 31, 2020 09:11

Comments are fixed.

@csordasmarton csordasmarton merged commit b16365c into Ericsson:master Aug 31, 2020
@csordasmarton csordasmarton deleted the markdownlint_support branch November 6, 2020 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruntib bruntib bruntib approved these changes

@dkrupp dkrupp Awaiting requested review from dkrupp dkrupp is a code owner

@gyorb gyorb Awaiting requested review from gyorb

Assignees
No one assigned
Labels
documentation 📖 Changes to documentation. enhancement 🌟 test ☑️ Adding or refactoring tests tools 🛠️ Meta-tag for all the additional tools supplied with CodeChecker: plist2html, tu_collector, etc.
Projects
None yet
Milestone
release 6.14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@csordasmarton @gyorb @bruntib