[server] Set analyzer name for clang-diagnostic checkers #2956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checkers that start with `clang-diagnostic-` are compiler warnings and these are not in the metadata.json file when storing results. We didn't handle this use case so we were not able to set analyzer names for these checkers previously. This commits solves this problem and set the analyzer name field for these checkers too.
gyorb
suggested changes
Sep 30, 2020
| @@ -2511,6 +2511,9 @@ def get_analyzer_name(report): | |||
| if report.metadata: | |||
| return report.metadata.get("analyzer", {}).get("name") | |||
|
|
|||
| if report.check_name.startswith('clang-diagnostic-'): | |||
| return 'clang-tidy' | |||
|
|
|||
There was a problem hiding this comment.
Should we add some default case if non of the above return some analyzer name? Something like unknown analyzer?
There was a problem hiding this comment.
By default if this field is not set it will be 'unknown':
codechecker/web/server/codechecker_server/database/run_db_model.py
Lines 305 to 307 in ff0b8c9
gyorb
approved these changes
Oct 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checkers that start with
clang-diagnostic-are compiler warnings and theseare not in the metadata.json file when storing results. We didn't handle this
use case so we were not able to set analyzer names for these checkers previously.
This commits solves this problem and set the analyzer name field for these
checkers too.