Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Full GUI userguide rewrite #3080

Merged
merged 1 commit into from
Jan 18, 2021

Conversation

csordasmarton
Copy link
Contributor

No description provided.

@csordasmarton csordasmarton added GUI 🎨 documentation 📖 Changes to documentation. refactoring 😡 ➡️ 🙂 Refactoring code. labels Dec 8, 2020
@csordasmarton csordasmarton added this to the release 6.16.0 milestone Dec 8, 2020
gyorb
gyorb previously requested changes Dec 8, 2020
web/server/vue-cli/src/assets/userguide/userguide.md Outdated Show resolved Hide resolved
web/server/vue-cli/src/assets/userguide/userguide.md Outdated Show resolved Hide resolved
web/server/vue-cli/src/assets/userguide/userguide.md Outdated Show resolved Hide resolved
web/server/vue-cli/src/assets/userguide/userguide.md Outdated Show resolved Hide resolved
web/server/vue-cli/src/assets/userguide/userguide.md Outdated Show resolved Hide resolved
web/server/vue-cli/src/assets/userguide/userguide.md Outdated Show resolved Hide resolved
web/server/vue-cli/src/assets/userguide/userguide.md Outdated Show resolved Hide resolved
web/server/vue-cli/src/assets/userguide/userguide.md Outdated Show resolved Hide resolved
web/server/vue-cli/src/assets/userguide/userguide.md Outdated Show resolved Hide resolved
web/server/vue-cli/src/assets/userguide/userguide.md Outdated Show resolved Hide resolved
Comment on lines +79 to +82
[postgresql](https://github.com/postgres/postgres),
[curl](https://github.com/curl/curl),
[bitcoin](https://github.com/bitcoin/bitcoin) or
[openssl](https://github.com/openssl/openssl) repositories.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary to list these products? These are just our "hello world" examples internally. I think these products have nothing to do with the user guide especially.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This list just demonstrates what can be a product.

web/server/vue-cli/src/assets/userguide/userguide.md Outdated Show resolved Hide resolved
web/server/vue-cli/src/assets/userguide/userguide.md Outdated Show resolved Hide resolved
<i>DETECTED BEFORE</i> the given date and <i>NOT FIXED BEFORE</i> the given
date.

### Regex based filters
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what's the official name of the * placeholder, but it is not a regex. Regex is something more complex and we don't support that. I'll try to find its official name and use that. Also * is not a quantifier (in regex it is, because there it means quantity of the preceding expression) here it is just a joker character (see the text a few lines below).

web/server/vue-cli/src/assets/userguide/userguide.md Outdated Show resolved Hide resolved
web/server/vue-cli/src/assets/userguide/userguide.md Outdated Show resolved Hide resolved
web/server/vue-cli/src/assets/userguide/userguide.md Outdated Show resolved Hide resolved
@bruntib
Copy link
Contributor

bruntib commented Jan 18, 2021

GUI tests are failing. Is this a known issue or should they run?

@csordasmarton
Copy link
Contributor Author

@bruntib I know about it, sometimes it fails for no reason. The virtual machine unable to start selenium server. I rebased my branch, so it will rerun the test. I hope now it will pass.

@csordasmarton
Copy link
Contributor Author

@bruntib Okay, now it is passed.

@bruntib bruntib dismissed gyorb’s stale review January 18, 2021 17:32

Changes have been done according to the review comments.

@bruntib bruntib merged commit ed84de2 into Ericsson:master Jan 18, 2021
@csordasmarton csordasmarton deleted the gui_userguide branch March 10, 2021 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📖 Changes to documentation. GUI 🎨 refactoring 😡 ➡️ 🙂 Refactoring code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants