-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[doc] Full GUI userguide rewrite #3080
Conversation
dd03178
to
d0884ee
Compare
d0884ee
to
336e740
Compare
[postgresql](https://github.com/postgres/postgres), | ||
[curl](https://github.com/curl/curl), | ||
[bitcoin](https://github.com/bitcoin/bitcoin) or | ||
[openssl](https://github.com/openssl/openssl) repositories. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it necessary to list these products? These are just our "hello world" examples internally. I think these products have nothing to do with the user guide especially.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This list just demonstrates what can be a product.
<i>DETECTED BEFORE</i> the given date and <i>NOT FIXED BEFORE</i> the given | ||
date. | ||
|
||
### Regex based filters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know what's the official name of the *
placeholder, but it is not a regex. Regex is something more complex and we don't support that. I'll try to find its official name and use that. Also *
is not a quantifier (in regex it is, because there it means quantity of the preceding expression) here it is just a joker character (see the text a few lines below).
336e740
to
4e0852a
Compare
GUI tests are failing. Is this a known issue or should they run? |
4e0852a
to
39825d6
Compare
@bruntib I know about it, sometimes it fails for no reason. The virtual machine unable to start selenium server. I rebased my branch, so it will rerun the test. I hope now it will pass. |
@bruntib Okay, now it is passed. |
Changes have been done according to the review comments.
No description provided.