[client] Diff "resolved" reports of remote to local #3129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruntib
force-pushed
the
empty_base_diff
branch
from
de8c00a to
3a07f62
Compare
csordasmarton
suggested changes
Jan 12, 2021
| "-o", "json"] | ||
|
|
||
| out = self.run_cmd(diff_cmd) | ||
| self.assertEqual(json.loads(out), []) |
There was a problem hiding this comment.
Please fix linter errors.
1. Analyze a project to "reports" dir. 2. Store it in run named "hello" 3. CodeChecker cmd diff -b reports -n hello --resolved This scenario shows all reports which is a bad behavior. When server side fetches a set of reports from database, it uses a filter object. If "reportHash" filter attribute is empty list, it means that no report hash was selected for diffing, i.e. it takes all reports into account.
bruntib
force-pushed
the
empty_base_diff
branch
from
3a07f62 to
e08ac58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This scenario shows all reports which is a bad behavior.
When server side fetches a set of reports from database, it uses a filter
object. If "reportHash" filter attribute is empty list, it means that no
report hash was selected for diffing, i.e. it takes all reports into
account.