Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gui] Refactoring product overview page #3147

Merged
merged 1 commit into from
Jan 28, 2021

Conversation

csordasmarton
Copy link
Contributor

Add helper tooltips for each widget on the product overview page which
describes the numbers, how these numbers are calculated and what kind of
filter affects these numbers.

Component statistics

<tooltip-help-icon>
This table shows a component statistics per severity
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This table shows a component statistics per severity
This table shows component statistics per severity

This table shows a component statistics per severity
levels.<br><br>

Each row can be expanded which will show a Checker Statistics
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Each row can be expanded which will show a Checker Statistics
Each row can be expanded which will show checker statistics

Comment on lines 96 to 97
This pie chart shows a Component Statistics in a visual
way.<br><br>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This pie chart shows a Component Statistics in a visual
way.<br><br>
This pie chart shows the checker severity distribution in the product.<br><br>


<tooltip-help-icon>
Shows the number of reports which were active in the last
<i>x</i> month/days.<br><br>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<i>x</i> month/days.<br><br>
<i>x</i> months/days.<br><br>

Shows the number of reports which were active in the last
<i>x</i> month/days.<br><br>

Reports which marked as <b>False positive</b> or
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Reports which marked as <b>False positive</b> or
Reports marked as <b>False positive</b> or

Shows the number of reports which were active in the last
<i>x</i> days.<br><br>

Reports which marked as <b>False positive</b> or
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Reports which marked as <b>False positive</b> or
Reports marked as <b>False positive</b> or

Comment on lines 30 to 32
For now reports which marked as <b>False positive</b> and
<b>Intentional</b> do not marked as resolved by these numbers.
A report is marked as resolved only when it is disspeared
from a storage.<br><br>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For now reports which marked as <b>False positive</b> and
<b>Intentional</b> do not marked as resolved by these numbers.
A report is marked as resolved only when it is disspeared
from a storage.<br><br>
For now reports marked as <b>False positive</b> or
<b>Intentional</b> are not considered to be resolved by these numbers.
A report is marked as resolved only when it disappeared
from a storage.<br><br>

@bruntib
Copy link
Contributor

bruntib commented Jan 27, 2021

In my opinion it is very confusing that different diagrams take different filter fields into account. I understand that the fixed "axes" of the diagrams can't be their parameters, but this is exactly what makes them unnecessary.

If we want to keep filter pane on the left, then we should at least visually indicate which fields serve as parameters to the specific diagrams in the future. For example hovering a diagram could fade out and make transparent unused filter fields.

Add helper tooltips for each widget on the product overview page which
describes the numbers, how these numbers are calculated and what kind of
filter affects these numbers.
@csordasmarton csordasmarton force-pushed the refactoring_product_overview branch from 4ef6507 to 6752c66 Compare January 28, 2021 11:12
@csordasmarton
Copy link
Contributor Author

@bruntib Yes, you are right, but now at least the users will see how these numbers are calculated. You can create a separate issue for this problem and we will discuss this problem how we can solve it nicely there.

@csordasmarton csordasmarton requested a review from bruntib January 28, 2021 11:13
@bruntib bruntib merged commit 580357d into Ericsson:master Jan 28, 2021
@csordasmarton csordasmarton deleted the refactoring_product_overview branch March 10, 2021 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants