Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gui] Allow to change the outstanding reports chart resolution #3179

Merged
merged 1 commit into from
Apr 16, 2021
Merged

[gui] Allow to change the outstanding reports chart resolution #3179

merged 1 commit into from
Apr 16, 2021

Conversation

csordasmarton
Copy link
Contributor

  • Add a resolution dropdown selector (day/week/month/year) to the Number of outstanding reports chart.
  • Handle wrong values (e.g: the interval should be lower than 31).
  • Save interval and resolution to the URL and on page load use these values.

Screenshots:
image
image

@csordasmarton csordasmarton added this to the release 6.16.0 milestone Feb 4, 2021
bruntib
bruntib requested changes Feb 15, 2021
View reviewed changes
Copy link
Contributor

@bruntib bruntib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This field should have some default value, because at page load it shows "Last 7 Resolution" and the chart doesn't show anything.

Minor question: are you planning to add tests to this dashboard feature, or we consider this as an early-phase feature which is not worth to test yet?

@csordasmarton
[gui] Allow to change the outstanding reports chart resolution
4bcd6d6 
- Add a resolution dropdown selector (day/week/month/year) to the Number of
outstanding reports chart.
- Handle wrong values (e.g: the interval should be lower than 31).
- Save interval and resolution to the URL and on page load use these values.
@csordasmarton csordasmarton force-pushed the outstanding_reports_chart_resolution branch from d790380 to 4bcd6d6 Compare April 6, 2021 09:57
@csordasmarton
Copy link
Contributor Author

@bruntib Good catch. I fixed it.

Unfortunately there is no test cases for the statistics pages yet. Later we can introduce some test cases because it would be good to test these features too. I created an issue for it: #3254

@csordasmarton csordasmarton requested a review from bruntib April 6, 2021 10:01
@bruntib bruntib merged commit e68a0cd into Ericsson:master Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruntib bruntib bruntib approved these changes

@dkrupp dkrupp Awaiting requested review from dkrupp

Assignees
No one assigned
Labels
enhancement 🌟 GUI 🎨
Projects
None yet
Milestone
release 6.16.0
Development

Successfully merging this pull request may close these issues.
2 participants
@csordasmarton @bruntib