Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gui] Show review status selector even if status change is disabled #3195

Merged
merged 1 commit into from
Mar 3, 2021
Merged

[gui] Show review status selector even if status change is disabled #3195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions web/server/vue-cli/src/components/Report/Report.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
</v-col>

<v-col
v-if="!isReviewStatusDisabled"
cols="auto"
class="review-status-wrapper pa-0"
align-self="center"
Expand Down Expand Up @@ -228,8 +227,6 @@ import {
ReviewData
} from "@cc/report-server-types";

import { mapGetters } from "vuex";

import { FillHeight } from "@/directives";
import CopyBtn from "@/components/CopyBtn";
import { UserIcon } from "@/components/Icons";
Expand Down Expand Up @@ -283,10 +280,6 @@ export default {
},

computed: {
...mapGetters([
"currentProductConfig",
]),

checkerId() {
return this.report ? this.report.checkerId : null;
},
Expand All @@ -297,13 +290,6 @@ export default {
return this.showComments
? maxCols - this.commentCols
: maxCols;
},

isReviewStatusDisabled() {
// Disable by default.
if (!this.currentProductConfig) return true;

return this.currentProductConfig.isReviewStatusChangeDisabled;
}
},

Expand Down
11 changes: 10 additions & 1 deletion web/server/vue-cli/src/components/Report/SelectReviewStatus.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
:items="items"
:hide-details="true"
:menu-props="{ contentClass: 'select-review-status-menu' }"
:disabled="isReviewStatusDisabled"
label="Set review status"
item-text="label"
item-value="id"
Expand Down Expand Up @@ -134,8 +135,16 @@ export default {

computed: {
...mapGetters([
"currentProductConfig",
"currentUser"
])
]),

isReviewStatusDisabled() {
// Disable by default.
if (!this.currentProductConfig) return true;

return this.currentProductConfig.isReviewStatusChangeDisabled;
}
},

created() {
Expand Down