Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[client] Handle no mandatory env var when using gerrit output #3196

Merged

Conversation

csordasmarton
Copy link
Contributor

Closes #3122

Print error messages and stop the command when no mandatory environment variables (CC_REPO_DIR, CC_CHANGED_FILES) are set when using gerrit output.

@csordasmarton csordasmarton added CLI 💻 Related to the command-line interface, such as the cmd, store, etc. commands bugfix 🔨 labels Feb 19, 2021
@csordasmarton csordasmarton force-pushed the gerrit_mandatory_env_vars branch from 3999996 to 632a0f5 Compare February 19, 2021 11:12
@csordasmarton csordasmarton requested a review from dkrupp February 19, 2021 11:12
analyzer/codechecker_analyzer/cmd/parse.py Outdated Show resolved Hide resolved
codechecker_common/output/gerrit.py Outdated Show resolved Hide resolved
@csordasmarton csordasmarton force-pushed the gerrit_mandatory_env_vars branch from 632a0f5 to 90adfbd Compare March 1, 2021 08:19
@csordasmarton csordasmarton requested a review from zomen2 March 1, 2021 08:20
@csordasmarton csordasmarton force-pushed the gerrit_mandatory_env_vars branch from 90adfbd to 3384496 Compare March 1, 2021 09:30
Print error messages and stop the command when no mandatory environment
variables (`CC_REPO_DIR`, `CC_CHANGED_FILES`) are set when using gerrit output.
@csordasmarton csordasmarton force-pushed the gerrit_mandatory_env_vars branch from 3384496 to a4b571f Compare March 2, 2021 07:59
@csordasmarton csordasmarton merged commit 474cb26 into Ericsson:master Mar 2, 2021
@csordasmarton csordasmarton deleted the gerrit_mandatory_env_vars branch March 10, 2021 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix 🔨 CLI 💻 Related to the command-line interface, such as the cmd, store, etc. commands
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Jenkins Gerrit Integration]: Faulty result on the Gerrit review page via HTTP post request
2 participants