[analyze] Fix duplication warning when creating failed zip #3213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When there is a compilation failure, we will try to create a failed zip file with source files. It is possible that we will try to add the same file multiple times but on different path: `a/b/c` and `/a/b/../b/c`. In this case CodeChecker will print out the following warning message: `UserWarning: Duplicate name:...` To avoid this problem we normalize the path before inserting it to the zip file.
csordasmarton
added
bugfix 🔨
analyzer 📈
zomen2
approved these changes
Feb 24, 2021
bruntib
approved these changes
Feb 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is a compilation failure, we will try to create a failed zip file
with source files. It is possible that we will try to add the same file
multiple times but on different path:
a/b/cand/a/b/../b/c. In thiscase CodeChecker will print out the following warning message:
UserWarning: Duplicate name:...To avoid this problem we normalize the path before inserting it to the
zip file.