Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[server] Cleanup unused data (comments, review statuses) #3243

Merged
merged 1 commit into from
Apr 16, 2021
Merged

[server] Cleanup unused data (comments, review statuses) #3243

merged 1 commit into from
Apr 16, 2021

Conversation

csordasmarton
Copy link
Contributor

@csordasmarton csordasmarton commented Mar 24, 2021 •
edited
Loading

Closes #3142

@csordasmarton csordasmarton added test ☑️ Adding or refactoring tests server 🖥️ labels Mar 24, 2021
@csordasmarton csordasmarton added this to the release 6.16.0 milestone Mar 24, 2021
@csordasmarton csordasmarton requested a review from bruntib March 24, 2021 11:16
dkrupp
dkrupp reviewed Mar 24, 2021
View reviewed changes
Copy link
Member

@dkrupp dkrupp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this cleanup job runs when there is a run removal, right?

@csordasmarton
Copy link
Contributor Author

@dkrupp Yes, it will run when the user removes a run or when the web server is started (similar to unused files).

whisperity
whisperity reviewed Mar 29, 2021
View reviewed changes
Copy link
Contributor

@whisperity whisperity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if a bug is reopened/reintroduced later? Will we lose all the comments that were previously posted to such a bug report?

web/server/codechecker_server/api/report_server.py Outdated Show resolved Hide resolved
web/server/codechecker_server/database/db_cleanup.py Outdated Show resolved Hide resolved
@bruntib bruntib merged commit 51a7491 into Ericsson:master Apr 16, 2021
@csordasmarton csordasmarton deleted the cleanup_unused_data branch January 28, 2022 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruntib bruntib bruntib approved these changes

@whisperity whisperity Awaiting requested review from whisperity

@dkrupp dkrupp Awaiting requested review from dkrupp

Assignees
No one assigned
Labels
server 🖥️ test ☑️ Adding or refactoring tests
Projects
None yet
Milestone
release 6.16.0
Development

Successfully merging this pull request may close these issues.

Review status and comment garbage collection
4 participants
@csordasmarton @whisperity @dkrupp @bruntib