[test] Fix non existen report directory test #3250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `test_non_existent_reports_directory` test assumes that on the default url (localhost:8001) doesn't run any server. Unfortunately for me a CodeChecker server was started on this port and this test cases is failed because the connection between the client and server was successfully created. To solve this problem we should get a free port on the host and we need to try to connect to this server. So this test case will always pass.
zomen2
approved these changes
Mar 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
test_non_existent_reports_directorytest assumes that on the defaulturl (localhost:8001) doesn't run any server. Unfortunately for me a
CodeChecker server was started on this port and this test cases is failed
because the connection between the client and server was successfully
created. To solve this problem we should get a free port on the host
and we need to try to connect to this server. So this test case will
always pass.