Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[analyzer] Fix yaml dumper #3331

Merged
merged 1 commit into from
May 25, 2021

Conversation

csordasmarton
Copy link
Contributor

If the key attribute (path) in the invocation-list.yml file is longer then
128 characters the yaml module will mark it as a complex key which is not
supported by the LLVM yaml parser. For this reason we will create an
LLVM compatible yaml dumper class which will mark these keys as non-complex
keys.

@csordasmarton csordasmarton added bugfix 🔨 analyzer 📈 Related to the analyze commands (analysis driver) labels May 25, 2021
@csordasmarton csordasmarton added this to the release 6.16.0 milestone May 25, 2021
@csordasmarton csordasmarton requested a review from bruntib May 25, 2021 12:35
@csordasmarton csordasmarton requested a review from martong as a code owner May 25, 2021 12:35
Copy link
Contributor

@martong martong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, great change!

Do you think it would make sense to copy an existing CTU test but with a long key? Just to make sure we never break the feature.

If the key attribute (path) in the invocation-list.yml file is longer then
128 characters the yaml module will mark it as a complex key which is not
supported by the LLVM yaml parser. For this reason we will create an
LLVM compatible yaml dumper class which will mark these keys as non-complex
keys.
@csordasmarton
Copy link
Contributor Author

@martong Good idea, I have extended our test cases.

@csordasmarton csordasmarton merged commit 7d7f3f0 into Ericsson:master May 25, 2021
@csordasmarton csordasmarton deleted the fix_yaml_dumper branch January 28, 2022 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyzer 📈 Related to the analyze commands (analysis driver) bugfix 🔨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants