[server] Unzip storage zip file to workspace directory #3347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the storage zip file is unzipped to the `/tmp` folder. It is possible that the disk size of the host machine is not so big and when the unzipped / decompressed zip size is too big that the user will get `No space left on device` exception. For this reason we will unzip the zip file to the workspace folder which can be configured during a server start and it can point to an extra network drive which size can be bigger than the host machine drive. This patch also removes our `TemporaryDirectory` class because it is available in the `tempfile` module since `Python 3.2`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the storage zip file is unzipped to the
/tmpfolder. It ispossible that the disk size of the host machine is not so big and when
the unzipped / decompressed zip size is too big that the user will
get
No space left on deviceexception.For this reason we will unzip the zip file to the workspace folder which
can be configured during a server start and it can point to an extra
network drive which size can be bigger than the host machine drive.
This patch also removes our
TemporaryDirectoryclass because it isavailable in the
tempfilemodule sincePython 3.2.