[analyzer] Create new diagnostic message hash #3402
Conversation
There was a problem hiding this comment.
First of all, thanks for this change Marci, great work!
I was wondering if it would be possible to generate and store both the context-free-v2 and the diagnostic-message hashes for a bugreport? The reason I am asking is that we might not know during the analysis time based on which hash we are going to browse the reports.
What's more, it would be really useful to list in a differential view all those bugs that have the same context-free-v2 but a different diagnostic-message hash. Actually, I think this is the real use case we want to achieve. Because we want the possibility to show how a checker's messaging changed/evolved with a patch.
Create a new hash that contains the messages on the report path. This report hash will contain the similar information as the `context-free-v2` hash + bug step messages: - file_name from the main diag section. - checker message. - line content from the source file if can be read up. All the whitespaces from the source content are removed. - column numbers from the main diag sections location. - bug step messages.
csordasmarton
force-pushed
the
diagnostic_message_hash
branch
from
e54abe6 to
6e9d946
Compare
As we discussed, the new hash in itself is enough to have this kind of diff that I want, so there is no need to have multiple hashes stored. |
Create a new hash that contains the messages on the report path.
This report hash will contain the similar information as the
context-free-v2hash + bug step messages: