Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test][cfg] Use clang-13 in the CI, uplift tests accordingly #3475

Merged
merged 1 commit into from
Nov 3, 2021

Conversation

steakhal
Copy link
Contributor

@steakhal steakhal commented Nov 2, 2021

The -Wunused-but-set-variable and -Wunused-but-set-parameter warnings were introduced by https://reviews.llvm.org/D100581, so had to suppress these warnings in the test file to make them forward compatible.

Let's see if the build bots are happy.

Copy link
Contributor

@csordasmarton csordasmarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please change the version number in this file too:

_CLANG_MIN_VERSION = {"major": 11, "minor": 0}
_TIDY_MIN_VERSION = {"major": 11, "minor": 0}

@csordasmarton csordasmarton added config ⚙️ test ☑️ Adding or refactoring tests labels Nov 2, 2021
@csordasmarton csordasmarton added this to the release 6.18.0 milestone Nov 2, 2021
@steakhal
Copy link
Contributor Author

steakhal commented Nov 2, 2021

Can you please change the version number in this file too:

_CLANG_MIN_VERSION = {"major": 11, "minor": 0}
_TIDY_MIN_VERSION = {"major": 11, "minor": 0}

The tests seem to run even on clang-11.

@steakhal
Copy link
Contributor Author

steakhal commented Nov 2, 2021

From the log, it's not clear to me what is failing. Any guidance?

Copy link
Contributor

@csordasmarton csordasmarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@csordasmarton csordasmarton merged commit 9f894e3 into Ericsson:master Nov 3, 2021
@steakhal steakhal deleted the use-clang-13 branch January 6, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config ⚙️ test ☑️ Adding or refactoring tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants