[gui] Fix weird file path filter #3479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes the file path filter at the selected items shows weird strings
for report count (`{"buffer": ...}`). This can be reproduced with the
following steps:
- Filter `File path filter` with a regex which matches only one
file path (e.g: `*main.cpp`) and apply the filter.
- Filter again with the same value but now select and apply the regex
filter option.
This commit will solve this problem and converts the report count value
to number properly.
bruntib
approved these changes
Nov 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the file path filter at the selected items shows weird strings
for report count (
{"buffer": ...}). This can be reproduced with thefollowing steps:
File path filterwith a regex which matches only onefile path (e.g:
*main.cpp) and apply the filter.filter option.
This commit will solve this problem and converts the report count value
to number properly.