[web] Update blame info #3488
[web] Update blame info #3488
Conversation
| for f in files: | ||
| blame_file = os.path.join(subdir, f) | ||
| file_path = blame_file[len(blame_root.rstrip("/")):] | ||
| blame_info, remote_url, tracking_branch = \ |
There was a problem hiding this comment.
We already getting and storing blame information on this part:
codechecker/web/server/codechecker_server/api/mass_store_run.py
Lines 384 to 385 in 85dd52d
We have to process every git blame info file only once and not multiple times.
There was a problem hiding this comment.
I chose not adding blame info when inserting new File and FileContent fields because the alternative solution (i.e. returning the list of newly inserted fields) was not convenient. For example gathering the information whether a File is newly inserted would require to add a second return value for add_file_record() function and this info should be transferred to __add_blame_info() through further return values and function parameters.
|
There is a typo in the commit message: stured -> stored. |
bruntib
force-pushed
the
update_blame_info
branch
2 times, most recently
from
5d27c3b to
0657558
Compare
When a run is stured with an old CodeChecker version then blame info is empty for the file contents. In a subsequent store we'd like to update blame info for these files.
bruntib
force-pushed
the
update_blame_info
branch
from
0657558 to
5b42427
Compare
When a run is stured with an old CodeChecker version then blame info is
empty for the file contents. In a subsequent store we'd like to update
blame info for these files.