Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Documentation for parse JSON output #3519

Merged
merged 1 commit into from
Dec 6, 2021

Conversation

csordasmarton
Copy link
Contributor

No description provided.

- `checker_name` (str): identifier of the rule (checker) that was evaluated
to produce the result.
- `severity` (str | null): CodeChecker severity level (optional).
- `report_hash` (str | null): unique report identifier (optional).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `report_hash` (str | null): unique report identifier (optional).
- `report_hash` (str | null): bug identifier hash (optional).

I think we should use the word "report" to an entity which belongs an entry in the "reports" table. In this sense multiple reports can have the same report_hash. So I think this hash doesn't identify a report, but the bug uniquely. This distinction may not be important for a user who is browsing the findings, but can be important for someone who consumes a JSON output in order to see that multiple reports may have the same hash.

@bruntib bruntib merged commit 612b726 into Ericsson:master Dec 6, 2021
@csordasmarton csordasmarton deleted the parse_json_output branch January 28, 2022 11:06
- `message` (str): message reported by the checker.
- `checker_name` (str): identifier of the rule (checker) that was evaluated
to produce the result.
- `severity` (str | null): CodeChecker severity level (optional).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you list in the docs, what are the possible values of severity? It's useful in order to filter severities > LOW for example. That was trivial when severity was numeric.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done: #3604

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📖 Changes to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants