Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certain Errors Fixed #3557

Merged
merged 1 commit into from
Dec 21, 2021
Merged

Certain Errors Fixed #3557

merged 1 commit into from
Dec 21, 2021

Conversation

Rakesh9100
Copy link
Contributor

Fixed the grammatical errors in readme.md file

Fixed some Spellings too in this file

@csordasmarton csordasmarton added the documentation 📖 Changes to documentation. label Dec 16, 2021
Copy link
Contributor

@csordasmarton csordasmarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this patch 😊 I have only one comment otherwise LGTM.

Can you please change the commit message and be a little bit more specific. Errors fixed is very generic and from it I don't know what kind of errors are fixed.

So I recommend to change it something to similar: [doc] Fix grammatical errors in the main readme

@Rakesh9100
Copy link
Contributor Author

Rakesh9100 commented Dec 16, 2021 via email

@csordasmarton
Copy link
Contributor

@Rakesh9100 I think something is not okay, because on the Commits tab it shows me 2 commits:
image

Only the second one is your commit. The first one comes from this PR: #3541. I think you rebased your branch in a wrong way. Can you please try to fix it?

@Rakesh9100
Copy link
Contributor Author

Rakesh9100 commented Dec 21, 2021 via email

Copy link
Contributor

@csordasmarton csordasmarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@csordasmarton csordasmarton added this to the release 6.19.0 milestone Dec 21, 2021
@csordasmarton csordasmarton merged commit 048741c into Ericsson:master Dec 21, 2021
@Rakesh9100 Rakesh9100 deleted the my-codechecker-changes branch April 2, 2022 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📖 Changes to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants