-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Certain Errors Fixed #3557
Certain Errors Fixed #3557
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this patch 😊 I have only one comment otherwise LGTM.
Can you please change the commit message and be a little bit more specific. Errors fixed
is very generic and from it I don't know what kind of errors are fixed.
So I recommend to change it something to similar: [doc] Fix grammatical errors in the main readme
Glad to help you out !!
I have changed the commit message according to your request. Please do check it out.
…On Thu, Dec 16, 2021 at 2:06 PM Márton Csordás ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Thank you for this patch 😊 I have only one comment otherwise LGTM.
Can you please change the commit message and be a little bit more
specific. Errors fixed is very generic and from it I don't know what kind
of errors are fixed.
So I recommend to change it something to similar: [doc] Fix grammatical
errors in the main readme
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3557 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARUQ4L7UX4UZWLIGLDSRKNLURGQJTANCNFSM5KFI6PIQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
--
[image: photo]
Rakesh Roshan
Student - B.Tech Computer Science and Engineering at Lovely Professional
University
A Jainamore, Bokaro steel city, Jharkhand
M +91-6203489100 <+91-6203489100>
E ***@***.*** ***@***.***>
W www.lpu.in <http://www.lpu.in>
[image: Social icon] <http://www.facebook.com/rakesh.roshan.7524/> [image:
Social icon] <http://www.instagram.com/rakesh250602/>
[image: App Social Buttons Image]
<http://www.linkedin.com/in/rakesh-roshan-9a65211a0>
Create your own email signature
<https://www.wisestamp.com/create-own-signature/?utm_source=promotion&utm_medium=signature&utm_campaign=create_your_own&srcid=>
|
@Rakesh9100 I think something is not okay, because on the Commits tab it shows me 2 commits: Only the second one is your commit. The first one comes from this PR: #3541. I think you rebased your branch in a wrong way. Can you please try to fix it? |
I have also seen it and i know that i rebased the branch commit in wrong
way first time and second time it happened perfectly but the first commit
came.
I searched for the way to fix it but i am unable to do it. If you know the
steps to fix this error, please let me know otherwise let it be since it
will not create any problem.
…On Tue, 21 Dec 2021, 1:23 pm Márton Csordás, ***@***.***> wrote:
@Rakesh9100 <https://github.com/Rakesh9100> I think something is not
okay, because on the Commits tab it shows me 2 commits:
[image: image]
<https://user-images.githubusercontent.com/6695818/146891803-63ec5891-9d7f-41e8-bb25-7fc3aa9ca2d8.png>
Only the second one is your commit. The first one comes from this PR:
#3541 <#3541>. I think you
rebased your branch in a wrong way. Can you please try to fix it?
—
Reply to this email directly, view it on GitHub
<#3557 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARUQ4L3NIBJLPAXQOR76HVTUSAW7VANCNFSM5KFI6PIQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixed the grammatical errors in readme.md file
Fixed some Spellings too in this file