[CI] Fix install of PPA clang-tidy in config coverage job
#3678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whisperity
added
dev env ⛑️
GitHub seems to have modified the base Ubuntu image which now comes with a specific version of `clang-tidy` pre-installed.
whisperity
force-pushed
the
fix/config-coverage-tidy-install
branch
from
72e3f97 to
45825a7
Compare
|
It seems like we got a couple new checkers in the meanwhile, failing the |
|
@steakhal That is normal! That job failing with the "non-configured checks" list getting emitted means that the script is doing its job. The issue this PR is fixing is that the job itself was unable to reach the stage where it can compare the list of checks, because installing Clang did not succeed. |
whisperity
commented
Jun 8, 2022
| - 'config/labels/analyzers/clang-tidy.json' | ||
| - 'config/labels/analyzers/clangsa.json' | ||
| pull_request: | ||
| paths: | ||
| - '.github/workflow/config_coverage.yml' | ||
| - '.github/workflow/config_label_check.py' | ||
| - '.github/workflows/config_coverage.yml' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub seems to have modified the base Ubuntu image which now comes with a specific version of
clang-tidypre-installed.The change happened last week because the job 10 days ago was successfully executed, while 3 days ago (last Sunday), we started observing the following failures across multiple projects:
Changing over to registering two top-level alternatives entries fixes the issue.