Import the suppressions per report #3693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruntib
requested changes
Jun 27, 2022
|
I fixed all your comments. Ready to be merged. |
dkrupp
force-pushed
the
suppression_fix
branch
2 times, most recently
from
cfe6a10 to
44675f8
Compare
bruntib
approved these changes
Jul 5, 2022
CodeChecker cmd suppress run_name -i <import_file> will only import suppressions for the run indicated by run_name, and not all reports. Suppressions are imported as single report suppressions instead of suppression rules. This is the behaviour the user expects when run name is given as a parameter to the command. This patch also fixes the changeReviewStatus(report_id, status, message) API function to change the review status of a single report only instead of all reports with the same hash.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CodeChecker cmd suppress run_name -i <import_file>
will only import suppressions for the run indicated by run_name,
and not all reports.
Suppressions are imported as single report suppressions
instead of suppression rules.
This is the behaviour the user expects when run name is given
as a parameter to the command.
This patch also fixes the changeReviewStatus(report_id, status, message)
API function to change the review status of a single report only
instead of all reports with the same hash.