[db] Garbage collection of analysis_info timeout #3775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruntib
added
enhancement 🌟
database 🗄️
bruntib
force-pushed
the
garbage_timeout_analysis_info
branch
from
f466e6e to
dcd324a
Compare
Szelethus
reviewed
Nov 8, 2022
| @@ -197,24 +197,37 @@ def upgrade_severity_levels(session_maker, checker_labels): | |||
|
|
|||
| def remove_unused_analysis_info(session_maker): | |||
| """ Remove unused analysis information from the database. """ | |||
| # Analysis info deletion is a relatively slow operation due to database | |||
| # cascades. Removing files in big chunks prevents reaching a potential | |||
There was a problem hiding this comment.
I get what you mean, but didn't you mean to say "smaller chunks"? (as opposed all in one go)
vodorok
approved these changes
Nov 8, 2022
| # cascades. Removing files in big chunks prevents reaching a potential | ||
| # database statement timeout. This hard-coded value is a safe choice | ||
| # according to some measurements. | ||
| CHUNK_SIZE = 500 |
There was a problem hiding this comment.
Is this batch size of 500 will completely resolve all database timeout during cleanup? If not maybe we should fall back to smaller size?
There was a problem hiding this comment.
Yes, it seems to fix the timeout issue. Of course it depends on the database manager settings, but we are aiming 2min timeout threshold and this looks a proper choice for that. I agree that chunking is not an elegant solution, but we used such hard-coded values at other parts of the code too. In the long terms we should review our database schema and find some possibilities for optimizations.
The garbage collection of analysis_info table has been restructured because the original query exceeded a 2min timeout.
bruntib
force-pushed
the
garbage_timeout_analysis_info
branch
from
dcd324a to
12535bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The garbage collection of analysis_info table has been restructured because the original query exceeded a 2min timeout.