Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Upgrade to Python 3.8 in GitHub Actions #3859

Merged
merged 1 commit into from
Mar 17, 2023

Conversation

bruntib
Copy link
Contributor

@bruntib bruntib commented Mar 14, 2023

No description provided.

@bruntib bruntib added this to the release 6.22.0 milestone Mar 14, 2023
@bruntib bruntib requested a review from Szelethus March 14, 2023 13:01
@bruntib bruntib requested a review from vodorok as a code owner March 14, 2023 13:01
@bruntib bruntib force-pushed the python38 branch 2 times, most recently from d09a1ac to f79fa71 Compare March 14, 2023 13:51
Copy link
Contributor

@vodorok vodorok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the pypy workflow also be done in one fell swoop?

.github/workflows/pypi.yml:20:          python-version: '3.6'
.github/workflows/pypi.yml:66:          python-version: '3.6'

We also have some documentation referencing python 3.6

docs/deps.md:18:  * [Python3](https://www.python.org/) (> 3.6)
docs/README.md:404:You will need at least Python version **`3.6`**.
docs/usage.md:68:- Install Python 3 (> 3.6)

And the following list that I found also mentions 3.6:

tools/tu_collector/setup.py:32:    python_requires='>=3.6',
tools/bazel/setup.py:32:    python_requires='>=3.6',
tools/report-converter/setup.py:33:    python_requires='>=3.6',
snap/snapcraft.yaml:20:      PYTHONPATH: ${SNAP}/usr/lib/python3.6
setup.py:184:    python_requires='>=3.6',
web/server/vue-cli/src/views/NewFeatures.vue:1093:            ported to Python 3 the minimal required version is <b>3.6</b>.

@bruntib
Copy link
Contributor Author

bruntib commented Mar 16, 2023

Thanks for this collection, it was really not a too complete change :)
However, I skipped the last one, because that is a "what's new" documentation for a previous release.

@bruntib bruntib requested a review from vodorok March 16, 2023 10:33
Copy link
Contributor

@vodorok vodorok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bruntib bruntib merged commit be10194 into Ericsson:master Mar 17, 2023
@bruntib bruntib deleted the python38 branch March 17, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants