[report-converter] Enable multiple input for report-converter #3897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vodorok
requested changes
May 2, 2023
| # Type of "values" can have any of the indicated types above. But in | ||
| # argument parser it is given by "nargs='+'", so it will be a list in | ||
| # this specific case. | ||
| assert isinstance(values, Sequence) |
There was a problem hiding this comment.
The example about defining custom actions in the python documentation show that checking the number of items can be done in the constructor
def __init__(self, option_strings, dest, nargs=None, **kwargs):
if nargs is None:
raise ValueError("nargs needed")
super().__init__(option_strings, dest, **kwargs)
https://docs.python.org/3/library/argparse.html#action
https://docs.python.org/3/library/argparse.html#argparse.Action
There was a problem hiding this comment.
Thanks, I didn't notice that there is a standard place for checking this precondition :)
bruntib
force-pushed
the
report_converter_multiple_inputs
branch
12 times, most recently
from
70ef995 to
f6f0b73
Compare
bruntib
force-pushed
the
report_converter_multiple_inputs
branch
from
f6f0b73 to
dddcd88
Compare
bruntib
force-pushed
the
report_converter_multiple_inputs
branch
from
dddcd88 to
1bde6cc
Compare
Sometimes dynamic analysis is executed for the code base several times with different parameters. The output of these analyses may go to different log files which are given to report-converter one-by-one. If there are reports for the same source file in different log output files then the resulting .plist files will be overwritten at a subsequent execution of report-converter. In this patch we make it possible to give multiple log files or directories containing log files to the report-converter. The reports in these files and directories will be collected all and will be converted to .plist without overriding the ones coming from a different log file.
bruntib
force-pushed
the
report_converter_multiple_inputs
branch
from
1bde6cc to
0c62f8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes dynamic analysis is executed for the code base several times with different parameters. The output of these analyses may go to different log files which are given to report-converter one-by-one. If there are reports for the same source file in different log output files then the resulting .plist files will be overwritten at a subsequent execution of report-converter.
In this patch we make it possible to give multiple log files or directories containing log files to the report-converter. The reports in these files and directories will be collected all and will be converted to .plist without overriding the ones coming from a different log file.