Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade nightwatch #3905

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Upgrade nightwatch #3905

wants to merge 1 commit into from

Conversation

vodorok
Copy link
Contributor

@vodorok vodorok commented May 10, 2023

No description provided.

@vodorok vodorok requested a review from bruntib as a code owner May 10, 2023 15:51
@Szelethus Szelethus added the dependencies 📦 Pull requests that update a dependency file label May 15, 2023
Szelethus
Szelethus requested changes May 15, 2023
View reviewed changes
Copy link
Contributor

@Szelethus Szelethus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't forget the labels and milestones. At the very least, I do find them helpful. Its not immediately obvious to me whether you want this for the bugfix release or not, so I can't always fill it out.

@bruntib bruntib added this to the release 6.22.2 milestone May 15, 2023
bruntib
bruntib requested changes May 15, 2023
View reviewed changes
Copy link
Contributor

@bruntib bruntib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I've just checked the GUI tests. Now it gives quite different kinds of errors. Is this a good thing, or a bad thing? :)

@bruntib bruntib modified the milestones: release 6.22.2, release 6.23.0 Jul 4, 2023
@dkrupp dkrupp modified the milestones: release 6.23.0, release 6.24.0 Oct 19, 2023
@whisperity whisperity added test ☑️ Adding or refactoring tests dev env ⛑️ Development environment labels Oct 19, 2023
@bruntib bruntib marked this pull request as draft March 21, 2024 10:52
@whisperity
Copy link
Contributor

I'd really like this to work, as dealing with old nightwatch lack of features was troubling when implementing #4202.

However, nightwatch version 3.y is out now as well. Can we do the migration in one step, or should it be separate steps for major version changes?

@whisperity whisperity added the javascript Pull requests that update JavaScript code (used by DependaBot) label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Szelethus Szelethus Szelethus requested changes

@bruntib bruntib bruntib requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
dependencies 📦 Pull requests that update a dependency file dev env ⛑️ Development environment javascript Pull requests that update JavaScript code (used by DependaBot) test ☑️ Adding or refactoring tests
Projects
None yet
Milestone
release 6.26.0
Development

Successfully merging this pull request may close these issues.
5 participants
@vodorok @whisperity @bruntib @Szelethus @dkrupp