Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[analyzer] Add --inferargs flag #4447

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Conversation

bruntib
Copy link
Contributor

@bruntib bruntib commented Feb 4, 2025

Analyzers can be given further flags that are forwarded verbatim to the analyzer invocation. These flags are provided in a text file which is given to --args flag. This flag was missing at Facebook Infer plugin.

@bruntib bruntib added CLI 💻 Related to the command-line interface, such as the cmd, store, etc. commands analyzer 📈 Related to the analyze commands (analysis driver) labels Feb 4, 2025
@bruntib bruntib added this to the release 6.25.0 milestone Feb 4, 2025
@bruntib bruntib requested review from noraz31 and cservakt February 4, 2025 08:38
Copy link
Collaborator

@cservakt cservakt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch looks good to me, but please fix the pylint detected issues. Right now, env is ambiguous.

Analyzers can be given further flags that are forwarded verbatim to the
analyzer invocation. These flags are provided in a text file which is
given to --<analyzer>args flag. This flag was missing at Facebook Infer
plugin.
@cservakt cservakt merged commit a9e7564 into Ericsson:master Feb 7, 2025
7 of 8 checks passed
@dkrupp
Copy link
Member

dkrupp commented Feb 10, 2025

Don't introduce global flags for analyzer plugins, becuase it kill the pluginability. The fb infer analyzer is an analyzer plugin and as such should not introduce a global codechecker parameter.

Please introduce this flag as an infer analyzer config option. e.g. CodeChecker analyzers --analyzer-config fbinfer

#4451

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyzer 📈 Related to the analyze commands (analysis driver) CLI 💻 Related to the command-line interface, such as the cmd, store, etc. commands
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants