Fix bug tree showing all bugs in the project #806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csordasmarton
suggested changes
Aug 15, 2017
| @@ -433,14 +433,15 @@ function (declare, domClass, dom, style, fx, Toggler, on, query, Memory, | |||
| that.bugStore.put(item); | |||
| }); | |||
|
|
|||
| var filepath = getProperFilePath(this.reportData.checkedFile); | |||
| var filter_file = new CC_OBJECTS.ReportFilter(); | |||
There was a problem hiding this comment.
We use camel case variable names in JavaScript. Please rename it to fileFilter.
whisperity
force-pushed
the
fix-bug_tree
branch
from
a312d0a to
851027a
Compare
csordasmarton
approved these changes
Aug 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #767.
This was broken in #768. @csordasmarton Could you review this?