More options vas conf #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you guys please review this? The code looks good to me, though I'm not familiar enough with VAS to ensure it is doing the right thing. |
|
Look all good to me. Tested in Stockholm. Btw, I will send another PR with two additional vas.conf options shortly. |
|
I end up with an empty [vas_auth] section at the end of my vas.conf since $vas_conf_vas_auth_uid_check_limit is unset. Is this an issue @jwennerberg ? If not, all else is good. |
|
No, it's fine to have an empty section in vas.conf. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New options in vas.conf