Support hiera_array for users.allow

[jwennerberg]

Add support for merging users.allow entries in Hiera.

No spec-test for this at the moment. Will refactor the spec-tests to incorporate tests for hiera.

[Phil-Friderici]

I have tested this successfully on RH 5.9. Works like expected :) 👍

Please add something to the README.md like:

users_allow_hiera_array
----------------------
Boolean to merges all found instances of vas::users_allow_entries in Hiera. This is useful for specifying user_allow entries at different levels of the hierarchy and having them all included in the catalog.
- *Default*: false

Optional: This will default to 'true' in future versions.

[ghoneycutt]

Suggest defaulting to true now since the functionality is all new.

[Phil-Friderici]

If you have worked around this missing feature before, you'll end up with double entries if this is set to true.

[ghoneycutt]

Ah, right on. I thought that the users_allow was also being added in this commit.

Nevermind me :)

[Phil-Friderici]

Thanks for commenting :)

[jwennerberg]

README updated

[anders-larsson]

I've been looking at this functionality for quite some time but haven't had time to do anything about it. Thanks!
My only though it regarding the variable name. "$users_allow_hiera_array" doesn't really describe what it does in my opinion. Maybe it should include merge or something similar?

Tested it on a RHEL6 and SLE11 and it worked well.

[Phil-Friderici]

In sudoers (PUA) module I named that something like 'hiera_merge', do you think this would be more self explaining ?

[jwennerberg]

users_allow_hiera_merge then perhaps? because we might want to add this functionality for user.override entries as well?

[Phil-Friderici]

users_allow_hiera_merge sounds very self explaing 👍

[anders-larsson]

Yes that sounds like a good name.