Working VAS module #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ability to run spec tests through travis
Fix style, documentation, and logic, without changing the nature of the code.
|
Can you update the README that this only works with Puppet v3 on ruby 1.8.7 and update the .travis.yml to allow failure from ruby 1.9 so this can pass spec tests? Once it passes travis, then we can merge. |
|
README updated and travis builds now pass. Should I take care of the commit history before we merge? |
|
Yes, cleaning up the commit history would be nice. |
|
If there are things you think can be improved upon, could you please add that as issues, so they are captured. |
|
@ghoneycutt are we ready to merge this now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested and workding on EL5, EL6 and Solaris.
Still a few things that could be improved, like the join-part for example. But I don't have a solution for that today.