Handle strings better in users.{allow,deny} #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wait a bit with merging this. |
anders-larsson
force-pushed
the
fix_puppetserver_each
branch
from
4c1094e to
b546f55
Compare
|
Please review it. Added spec tests for strings in users.allow |
anders-larsson
force-pushed
the
fix_puppetserver_each
branch
from
b546f55 to
898285c
Compare
jwennerberg
pushed a commit
that referenced
this pull request
Feb 2, 2015
Handle strings better in users.{allow,deny}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Puppetserver's ruby intepreter is more strict than the previously used intepreter used by Puppet. It's no longer allow to do .each on strings. This commit prevents the error below from occuring if users_{allow,deny}_entries is an string.