Add ability to just unjoin domain

[propyless]

No description provided.

[propyless]

lemme just do some tests on live staging servers

[propyless]

puppet agent -t --environment test_vas
Info: Retrieving pluginfacts
Info: Retrieving plugin
Info: Loading facts
Info: Caching catalog for themostawesomenode.awesome.com
Info: Applying configuration version 'this_cataogue_was_generated_by_the_best_server'
Notice: /Stage[main]/Vas/Exec[vas_unjoin]/returns: executed successfully
Notice: Finished catalog run in 14.18 seconds
[root@themostawesomenode ~]# /opt/quest/bin/vastool status
Host:   <themostawesomenode.awesome.com, Linux x86_64>
Date:   <Fri Apr 29 10:38:09 CEST 2016>
QAS:    <4.1.0>
Domain: <N/A>
CRITICAL: 106 /etc/opt/quest/vas/vas.conf missing default_realm setting, is QAS joined?
Result: <Critical test(s) failed> (0 seconds)(v0.7.6)

[propyless]

@Phil-Friderici ping!

[Phil-Friderici]

@propyless looks like the code has much more changes than the tests. How come ?

[Phil-Friderici]

@propyless never mind! The diff doesn't show the changed indenting very well.

[propyless]

:)

Mvh
Takeshi

On 4 maj 2016, at 09:32, Phil Friderici notifications@github.com wrote:

@propyless never mind! The diff doesn't show the changed indenting very well.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

[propyless]

I have identified some issues with the PR which I will resolve...

[Phil-Friderici]

@propyless you'll need to add this to your Puppet code:

# lint:ignore:only_variable_string

like here: [redacted]

[propyless]

You are linking to a private repository to which I do not have access ;)
Also it was a mistake in the code on my part so I've fixed that now

[Phil-Friderici]

oh! sorry, but I see the specs are passing again 👍

[propyless]

I also added a bonus commit that fixes the logic in the if statement for vas migration part.

[Phil-Friderici]

got positive feedback from our VAS specialist :)

[Phil-Friderici]

@propyless Thanks a lot! Released in v0.18.0
Enjoy your vacation days ☀️ have phun and a good start afterwards 🍀