feat: support auto n to skip n confirmations
#346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to c035a16 in 30 seconds
More details
- Looked at
52lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_4fiilZwktGdAXVYS
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
gptme/util/ask_execute.py
Outdated
| if answer == "auto": | ||
| return (override_auto := True) | ||
| # secret option to skip asking for a number of times | ||
| match = re.match(r'(auto)(?: (\d+))?', answer) |
There was a problem hiding this comment.
The regex pattern should be anchored to the start of the string to avoid unexpected matches. Use ^ at the beginning of the pattern.
Suggested change
| match = re.match(r'(auto)(?: (\d+))?', answer) | |
| match = re.match(r'^(auto)(?: (\d+))?', answer) |
There was a problem hiding this comment.
Don't think it's necessary really. user might type a space before auto
There was a problem hiding this comment.
Also compiled the regex
|
closes #332 |
ErikBjare
reviewed
Dec 18, 2024
gptme/util/ask_execute.py
Outdated
Comment on lines
34
to
35
| #Compiled regex pattern | ||
| pattern = re.compile(r'(auto)(?: (\d+))?') |
There was a problem hiding this comment.
Call this something like re_auto, I don't think we need to compile it, at least not at import-time.
ErikBjare
reviewed
Dec 18, 2024
|
Nice! |
ErikBjare
changed the title
ErikBjare
changed the title
auto n to skip n confirmations
|
Forgot to [auto] as an option displayed in confirmation prompt. Guess it
remains secret?
…On Thu, 19 Dec 2024, 15:03 Erik Bjäreholt, ***@***.***> wrote:
Merged #346 <#346> into master.
—
Reply to this email directly, view it on GitHub
<#346 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AO6ENNOYJ7ZUJ4VKOHSZJI32GKYYFAVCNFSM6AAAAABTYHLHXSVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJVG4YTMNRTGY3TIMA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
*add
…On Thu, 19 Dec 2024, 15:08 Brayo Vuku, ***@***.***> wrote:
Forgot to [auto] as an option displayed in confirmation prompt. Guess it
remains secret?
On Thu, 19 Dec 2024, 15:03 Erik Bjäreholt, ***@***.***>
wrote:
> Merged #346 <#346> into master.
>
> —
> Reply to this email directly, view it on GitHub
> <#346 (comment)>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AO6ENNOYJ7ZUJ4VKOHSZJI32GKYYFAVCNFSM6AAAAABTYHLHXSVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJVG4YTMNRTGY3TIMA>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #332
Important
Adds limited confirmation skips to
ask_execute()usingauto_skip_countinask_execute.py.auto_skip_countinask_execute.pyto limit the number of confirmation skips.ask_execute()to decrementauto_skip_countwhen skipping confirmation.ask_execute().remodule inask_execute.pyfor regex operations.This description was created by
for c035a16. It will automatically update as commits are pushed.