-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add inline replies to notifications #221
Conversation
d748f01
to
1c80c60
Compare
@ErikReider, do I get it right that inline replies will work on Sway after swaywm/sway#7587 is merged? 🤔 |
Will work now, but only in the control center. We check if the compositor supports the ON_DEMAND interactivity which is required to get keyboard focus on floating notifications which is added in that PR :) |
Fixes: #179
Had to do a lot of tweaking in this PR due to a Notification essentially being a GtkButton with content inside of it. I replaced said GtkButton with an GtkEventBox that behaves like a button but respects children with input.
Todo:
Make use of(Works in Hyprland so I pushed a PR to Sway to fix this issue)KeyboardMode.ON_DEMAND
to be able to focus the GtkEntry when in NotiWindow. (Can't test in Sway. Maybe just support in CC if WM only supports layershell v3?). Alt methodTesting:
notify-send 'Title' 'body' -A inline-reply=Text
or
https://tests.peter.sh/notification-generator/
Everything is done here, just need to make sure that it works as expected in Sway, swaywm/sway#7587