Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: json backup are messed up and when updated to v7 it load the backup #95

Open
3 tasks done
broken1arrow opened this issue Feb 5, 2022 · 13 comments
Open
3 tasks done
Assignees
Labels
bug Fault in the plugin v7

Comments

@broken1arrow
Copy link

Checklist

  • Are you using the latest version/snapshot of HeadsPlus?
  • Have you checked to see if others have submitted the same bug report?
  • Have you been able to reproduce the bug more then once?

Description of the bug

When upgrade from v6 to v7 it seams it use the json to get the data and it mess up the stats. Have also send privately the original to you. Use latest on spigot.
https://pastebin.com/kJa8Mi9n

Steps To Reproduce

I don´t know excitably when this happen, we have run heads plus for years and only be real problem when update to v7.

Additional Information

use papermc 1.18.1 mysql and I think we start with v5 and have upgrade wen new version is out.
@Thatsmusic99
Copy link
Collaborator

This being opened reminded me that I actually moved my own server data onto a test server to check the update from 1.16 to 1.18, and noticed a lot of errors that most likely contributed to this. I'll see if I can try using bulk updates instead.

@Thatsmusic99 Thatsmusic99 added bug Fault in the plugin v7 labels Feb 5, 2022
@Thatsmusic99
Copy link
Collaborator

Whilst I believe I've been able to fix the majority of issues caused in the transition, I've not been able to fully verify this and will need more time to check this since I've noticed some data being skipped.

@Thatsmusic99 Thatsmusic99 self-assigned this Feb 6, 2022
Thatsmusic99 added a commit that referenced this issue Feb 13, 2022
@broken1arrow
Copy link
Author

Interesting to see if you can get the plugin to read the damage json file or if it works to fix it manually.

@Thatsmusic99
Copy link
Collaborator

I quite honestly don't remember the downfalls of this... I think it works best if the data.db file is reset prior so data isn't duplicated. I must admit there was a lot of consideration I took into account when repairing this since I should've tested a large dataset before v7 was released, and that's on me, I apologise about that. I considered adding the transition data onto existing data, but then that would result in data being transferred prior being doubled, and I'd say that's a lot worse than just letting the original data take over.

The most recent dev build should address the majority of transition problems as I mentioned, still not 100% on it but there's a significant improvement.

@Thatsmusic99
Copy link
Collaborator

There was a recent update to this where I fixed another portion of the transition issues, can I ask if 7.0.5 performs any better?

@broken1arrow
Copy link
Author

There was a recent update to this where I fixed another portion of the transition issues, can I ask if 7.0.5 performs any better?

I not try it out yet. But can do it now. But I guess the data some are gone now will not be fixed if I understand your last message right?

@Thatsmusic99
Copy link
Collaborator

Resetting data may work best was the main message, apologies if it wasn't clear - I didn't make the backup data add onto the new data due to the risk of duplication if player A's (for example) data was restored successfully beforehand.

@broken1arrow
Copy link
Author

Resetting data may work best was the main message, apologies if it wasn't clear - I didn't make the backup data add onto the new data due to the risk of duplication if player A's (for example) data was restored successfully beforehand.

Alright, will be little work because we use MySQL and I´m not soo good on the commands to remove x players data from the webb browser or restore only one table/database.

But will see if I can fix it manually instead for try remove data and it not restore data as it should (is at least easier an hope head plus fix it).

@Thatsmusic99
Copy link
Collaborator

Have still found some issues with the transfer tool, will dig a bit deeper to see what's wrong.

@broken1arrow
Copy link
Author

Have still found some issues with the transfer tool, will dig a bit deeper to see what's wrong.

Hi sorry I not update you I only test new version on test server. But I didn't know how to restore older db I can't test transfer tool properly.

But the version seams to work but not have time to test every thing.

@Thatsmusic99
Copy link
Collaborator

It's fine, I'm working on updating a server internally at my job and it uses HeadsPlus, but when I noticed the issues that arose from trying to update it, I figured it's not quite done. Once I yield better results from this dataset I have I think we'll be more in the clear.

@Thatsmusic99
Copy link
Collaborator

important update

image

There's definitely still something lurking though, even if the plugin just started suddenly working for reasons beyond me.

@broken1arrow
Copy link
Author

important update

image

There's definitely still something lurking though, even if the plugin just started suddenly working for reasons beyond me.

Yeah I recognize this behavior. When something start working for no reason and later understand way (some cases you don't get way it works) :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fault in the plugin v7
Projects
None yet
Development

No branches or pull requests

2 participants