Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes cache in CI #244

Merged
merged 2 commits into from
Dec 14, 2020
Merged

Fixes cache in CI #244

merged 2 commits into from
Dec 14, 2020

Conversation

artplan1
Copy link
Contributor

@artplan1 artplan1 marked this pull request as draft December 14, 2020 09:22
@artplan1 artplan1 marked this pull request as ready for review December 14, 2020 09:35
@artplan1 artplan1 marked this pull request as draft December 14, 2020 09:37
@artplan1 artplan1 force-pushed the ci-fixes branch 4 times, most recently from 81159f4 to f9eea1e Compare December 14, 2020 09:52
@artplan1 artplan1 marked this pull request as ready for review December 14, 2020 11:01
@artplan1
Copy link
Contributor Author

hey @excid3,
I split tests to workflows for each ruby/rails versions. Lmk what you think about this approach

@excid3
Copy link
Collaborator

excid3 commented Dec 14, 2020

This looks great @artplan1 🙏

@excid3 excid3 merged commit 8680e22 into ErwinM:master Dec 14, 2020
@excid3 excid3 mentioned this pull request Dec 14, 2020
Closed
@artplan1
Copy link
Contributor Author

@excid3 I see that sqlite installation step says that is already installed, maybe we can 🔪 it?

image

@artplan1 artplan1 deleted the ci-fixes branch December 14, 2020 16:56
@excid3
Copy link
Collaborator

excid3 commented Dec 14, 2020

Yeah! That'd be super nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@artplan1 @excid3