Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow lambda for require_tenant #274

Merged
merged 5 commits into from
Feb 1, 2022
Merged

Allow lambda for require_tenant #274

merged 5 commits into from
Feb 1, 2022

Conversation

cmer
Copy link
Contributor

@cmer cmer commented Jan 29, 2022

This feature offers extra flexibility by determining if a tenant should be enforced based on additional context.

@cmer
Allow setting lambda for require_tenant
b55da4a 
This feature offers extra flexibility by determining if a tenant should be enforced based on additional context.
excid3
excid3 requested changes Jan 29, 2022
View reviewed changes
Copy link
Collaborator

@excid3 excid3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also add some documentation about this method and its expected return value. Other than those couple things, I think this looks good. 👍

lib/acts_as_tenant.rb Outdated Show resolved Hide resolved
cmer and others added 3 commits January 31, 2022 15:03
excid3
excid3 reviewed Feb 1, 2022
View reviewed changes
lib/acts_as_tenant.rb Outdated Show resolved Hide resolved
@excid3 excid3 merged commit 5fa4851 into ErwinM:master Feb 1, 2022
@cmer cmer deleted the allow_lambda_for_require_tenant branch February 1, 2022 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@excid3 excid3 excid3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmer @excid3