Fix warning on instantiate object on Android N+ #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
objenesis in the version 2.3 (https://github.com/easymock/objenesis/releases/tag/2.3) fixed important warning caused by using private ObjectStream api on Android N+. I'm a developer of Paper DB lib (https://github.com/pilgr/Paper) and happy to use Kryo serialization! But I noticed users started to failing issues with a warning happening on read data on Android N and above `ObjectStreamClass.newInstance(Class<?>, long) is private API and will be removed in a future Android release`. I realized Objenesis fixed it, but Kryo 4.0 unfortunately uses outdated version. I temporary fixed this warning in the lib by forcing use of Objenesis 2.3. But would be awesome to have a new version of Kryo to include such dependency update. Thanks!
|
I'd like to know when the release is stable, to update my libs too. Thanks for the fix! |
|
And for Android O, it is not a warning anymore but an UnsupportedOperationException. |
|
So we should update objenesis to 2.5.1, right? Can you do this here? |
|
@magro sure. I've changed to the minimal vital version just to avoid any other side effects for Kryo. But seems to be updating to 2.5.1 shouldn't break anything according to the release notes. |
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
objenesis in the version 2.3 (https://github.com/easymock/objenesis/releases/tag/2.3) fixed important warning caused by using private ObjectStream api on Android N+.
I'm a developer of Paper DB lib (https://github.com/pilgr/Paper) and happy to use Kryo serialization!
But I noticed users started to failing issues with a warning happening on read data on Android N and above
ObjectStreamClass.newInstance(Class<?>, long) is private API and will be removed in a future Android release.I realized Objenesis fixed it, but Kryo 4.0 unfortunately uses outdated version. I temporary fixed this warning in the lib by forcing use of Objenesis 2.3. But would be awesome to have a new version of Kryo to include such dependency update.
Thanks!