Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[884] Fix eclipse project setup: Add JUnit 5, ByteBuddy #887

Merged

Conversation

JanecekPetr
Copy link
Contributor

@JanecekPetr JanecekPetr commented Feb 24, 2022

As discussed in #884:

  • switched JUnit 4 for JUnit 5
  • added ByteBuddy for the benchmarks project
  • and, most controversially, switched to JDK 11 as there are classes using Java 9+ features. I can roll this back, but it makes a fair amount of classes uncompilable.

@theigl
Copy link
Collaborator

theigl commented Feb 24, 2022

@JanecekPetr:

switched JUnit 4 for JUnit 5

JUnit 5 provides a single (unfortunately named) artifact as well:

An executable junit-platform-console-{platform-version}-standalone.jar artifact containing the Jupiter and Vintage test engines with all dependencies is generated by the default build process, stored in junit-platform-console/build/libs and published to the Maven Central repository. It provides hassle-free usage of JUnit 5 in projects that manually manage their dependencies similar to the plain-old JAR known from JUnit 4.

Could you try if this artifact works for the build? A single JAR would be much easier to manage.

and, most controversially, switched to JDK 11 as there are classes using Java 9+ features. I can roll this back, but it makes a fair amount of classes uncompilable.

We should be safe, since our CI builds still run the tests on JDK 8.

@JanecekPetr
Copy link
Contributor Author

Fair enough, fixed!

@theigl
Copy link
Collaborator

theigl commented Feb 25, 2022

We should be safe, since our CI builds still run the tests on JDK 8.

Sorry I wasn't really clear here: I meant, that you can change the JDK to 11 if you want, because our CI build will catch any incompatibilities with JDK 8 in the main source folder.

LGTM!

@theigl theigl merged commit 7bc4139 into EsotericSoftware:master Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants