[CDN] Rate limiting - DDoS protection #3774
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8cecb2f.
rob-maron
commented
Nov 15, 2024
Comment on lines
8
to
18
| async-trait = { workspace = true } | ||
| clap = { workspace = true } | ||
| committable = { workspace = true } | ||
| derive_more = { workspace = true } | ||
| futures = { workspace = true } | ||
| hotshot-types = { path = "../types" } | ||
| serde = { workspace = true } | ||
| thiserror = { workspace = true } | ||
| tagged-base64 = { workspace = true } | ||
| thiserror = { workspace = true } | ||
| tide-disco = { workspace = true } | ||
| toml = { workspace = true } |
There was a problem hiding this comment.
cargo-sort did this
Comment on lines
-15
to
+32
| async-trait = { workspace = true } | ||
| anyhow = { workspace = true } | ||
| sha3 = "^0.10" | ||
| async-lock = { workspace = true } | ||
| async-trait = { workspace = true } | ||
| committable = { workspace = true } | ||
| hotshot = { path = "../hotshot" } | ||
| hotshot-types = { path = "../types" } | ||
| hotshot-task-impls = { path = "../task-impls", version = "0.5.36", default-features = false } | ||
| hotshot-types = { path = "../types" } | ||
| jf-vid = { workspace = true } | ||
| rand = { workspace = true } | ||
| thiserror = { workspace = true } | ||
| reqwest = { workspace = true } | ||
| serde = { workspace = true } | ||
| sha2 = { workspace = true } | ||
| sha3 = "^0.10" | ||
| thiserror = { workspace = true } | ||
| time = { workspace = true } | ||
| async-lock = { workspace = true } | ||
| jf-vid = { workspace = true } | ||
| vbs = { workspace = true } | ||
| url = { workspace = true } | ||
| reqwest = { workspace = true } | ||
| tokio = { workspace = true } | ||
| url = { workspace = true } | ||
| vbs = { workspace = true } |
| @@ -0,0 +1,577 @@ | |||
| #![allow(clippy::unnecessary_wraps)] | |||
There was a problem hiding this comment.
This file contains the majority of the changes
Comment on lines
+96
to
+104
| /// A sample representing the number of bytes processed per period | ||
| #[derive(Clone)] | ||
| pub struct Sample { | ||
| /// The number of bytes processed | ||
| num_bytes: f64, | ||
|
|
||
| /// The time of the last commit | ||
| last_committed_time: Instant, | ||
| } |
There was a problem hiding this comment.
This Sample is held locally for each CDN connection and is used to occasionally the global average
| }; | ||
|
|
||
| // Check against the `GCR` instance, skipping if we're rate limited | ||
| // If we hit a parameter error, we'll process the message anyway |
There was a problem hiding this comment.
A parameter error is internal to Gcr, it can be hit if, say, you try to update the average to zero. This makes it so we don't accidentally block all messages everywhere if there was an issue with that
| @@ -0,0 +1,90 @@ | |||
| use std::marker::PhantomData; | |||
|
|
|||
There was a problem hiding this comment.
This file has just been moved
| use bincode::Options; | ||
| use cdn_broker::reexports::crypto::signature::{Serializable, SignatureScheme}; | ||
| use hotshot_types::{traits::signature_key::SignatureKey, utils::bincode_opts}; | ||
|
|
There was a problem hiding this comment.
This file has just been moved
| @@ -0,0 +1,28 @@ | |||
| use hotshot_types::traits::metrics::{Counter, Metrics, NoMetrics}; | |||
|
|
|||
| /// CDN-specific metrics | |||
There was a problem hiding this comment.
This file has just been moved
| pub mod definition; | ||
| /// The metrics for the Push CDN | ||
| pub mod metrics; | ||
|
|
There was a problem hiding this comment.
This was the big file everything else moved from
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successor to #3664
This PR:
Implements CDN rate limiting. Let me describe it:
Reviewers:
Most of the changes are in a single file,
message_hook.rs. The majority of the rest of the changes are breaking out the CDN code into smaller, easily-digestible files