Add remaining *2 types #3932
Merged
Add remaining *2 types #3932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaszrzasik
approved these changes
Dec 5, 2024
crates/task-impls/src/da.rs
Outdated
crates/task-impls/src/da.rs
Outdated
| encoded_transactions: Arc::clone(encoded_transactions), | ||
| metadata: metadata.clone(), | ||
| // Upon entering a new view we want to send a DA Proposal for the next view -> Is it always the case that this is cur_view + 1? | ||
| view_number, | ||
| epoch_number: self.cur_epoch, |
There was a problem hiding this comment.
This is fine here because we're proposing a new block and we don't know its block number yet. We need to rely on the task keeping track of the current epoch.
There was a problem hiding this comment.
your comment led me to look at this again, and I think I fixed it "properly": 3ef6a5b
this now takes its epoch number directly from the ViewChange event that triggered the transaction request
crates/task-impls/src/network.rs
Outdated
| @@ -115,18 +114,34 @@ impl<TYPES: NodeType> NetworkMessageTaskState<TYPES> { | |||
| HotShotEvent::UpgradeVoteRecv(message) | |||
| } | |||
| GeneralConsensusMessage::HighQc(qc) => HotShotEvent::HighQcRecv(qc, sender), | |||
| GeneralConsensusMessage::Proposal2(proposal) => { | |||
| HotShotEvent::QuorumProposalRecv(convert_proposal(proposal), sender) | |||
There was a problem hiding this comment.
Is this conversion here necessary?
There was a problem hiding this comment.
oops. removed: 18a6c10
pls148
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the remaining new types. This includes logic for
DaData2and its associated vote/certificate, but not for any timeout or view sync types. Those require some additional changes, which are being made in #3893.Key places to review:
The changes in
task-implsare the most relevant things to review; the remaining changes are mostly boilerplate for the added types.