Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Expose request-response protocol to application layer #3988

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

crStiv
Copy link

@crStiv crStiv commented Dec 25, 2024

Closes #3871

This PR:

  • Implements request-response protocol for network layer
  • Adds new types for network requests and responses
  • Exposes network functionality to application layer through RequestHandler trait
  • Implements basic request types (LeafByHeight, PayloadByVidCommitment, etc.)

This PR does not:

  • Implement specific request handlers for all request types (will be added based on application needs)
  • Add comprehensive error handling (will be addressed in follow-up PRs)

Key places to review:

  • crates/hotshot/src/networking/request_response.rs - New protocol implementation
  • crates/hotshot/src/networking/mod.rs - Module exports and organization

How to test this PR:

  • Currently includes only type definitions and traits
  • Unit tests will be added in follow-up commits

@crStiv crStiv requested a review from bfish713 as a code owner December 25, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Networking] - Expose request-response protocol to application layer
1 participant