Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prod check #61

Merged
merged 4 commits into from
Aug 12, 2022
Merged

Prod check #61

merged 4 commits into from
Aug 12, 2022

Conversation

chancharles92
Copy link
Collaborator

close #58

Bugs detected:

  1. The final query vector should have length nv + 1.
  2. The final query vector should be (0, 1, 1, ..., 1) rather than (1, 1, ..., 1, 0) because arkworks' MLE uses big-endian format.

cc @zhenfeizhang

zhenfeizhang
zhenfeizhang reviewed Aug 12, 2022
View reviewed changes
poly-iop/src/prod_check/mod.rs Outdated Show resolved Hide resolved
poly-iop/src/prod_check/mod.rs Outdated Show resolved Hide resolved
poly-iop/src/prod_check/mod.rs Show resolved Hide resolved
poly-iop/src/prod_check/mod.rs Outdated Show resolved Hide resolved
poly-iop/src/prod_check/util.rs Show resolved Hide resolved
poly-iop/src/prod_check/mod.rs Show resolved Hide resolved
poly-iop/Cargo.toml Show resolved Hide resolved
@chancharles92 chancharles92 merged commit 8281e7c into main Aug 12, 2022
@chancharles92 chancharles92 deleted the prod-check branch November 22, 2022 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhenfeizhang zhenfeizhang zhenfeizhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

product check
2 participants
@chancharles92 @zhenfeizhang