Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update crypto_box requirement from 0.7.1 to 0.8.1 #107

Merged
merged 3 commits into from
Aug 18, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 16, 2022

Updates the requirements on crypto_box to permit the latest version.

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Updates the requirements on [crypto_box](https://github.com/RustCrypto/nacl-compat) to permit the latest version.
- [Release notes](https://github.com/RustCrypto/nacl-compat/releases)
- [Commits](RustCrypto/nacl-compat@crypto_box-v0.7.1...crypto_box-v0.8.1)

---
updated-dependencies:
- dependency-name: crypto_box
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file rust Rust or rust toolchains related labels Aug 16, 2022
@alxiong
Copy link
Contributor

alxiong commented Aug 17, 2022

I'm a little confused with the updated API, RustCrypto/traits#1087, after clarification from Tony I will proceed to make a PR to upgrade our crypto_box dependency.

@alxiong alxiong self-assigned this Aug 18, 2022
@alxiong
Copy link
Contributor

alxiong commented Aug 18, 2022

Please take a read of my comments in RustCrypto/traits#1087 (comment)

In future design of our API, we could also consider my_fn(mut rng: impl CryptoRng + RngCore) over my_fn<R: CryptoRng+RngCore>(rng: &mut R).
(not saying we necessarily should, but just an option)

cc @chancharles92 @zhenfeizhang @mrain

Copy link
Contributor

@mrain mrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@alxiong alxiong merged commit 535e190 into main Aug 18, 2022
@alxiong alxiong deleted the dependabot/cargo/crypto_box-0.8.1 branch August 18, 2022 14:22
@mrain mrain mentioned this pull request Aug 23, 2022
6 tasks
sveitser pushed a commit that referenced this pull request Sep 30, 2022
* Update crypto_box requirement from 0.7.1 to 0.8.1

Updates the requirements on [crypto_box](https://github.com/RustCrypto/nacl-compat) to permit the latest version.
- [Release notes](https://github.com/RustCrypto/nacl-compat/releases)
- [Commits](RustCrypto/nacl-compat@crypto_box-v0.7.1...crypto_box-v0.8.1)

---
updated-dependencies:
- dependency-name: crypto_box
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

* update with crypto_box new API

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Alex Xiong <alex.xiong.tech@gmail.com>
sveitser pushed a commit that referenced this pull request Nov 29, 2022
* Update crypto_box requirement from 0.7.1 to 0.8.1

Updates the requirements on [crypto_box](https://github.com/RustCrypto/nacl-compat) to permit the latest version.
- [Release notes](https://github.com/RustCrypto/nacl-compat/releases)
- [Commits](RustCrypto/nacl-compat@crypto_box-v0.7.1...crypto_box-v0.8.1)

---
updated-dependencies:
- dependency-name: crypto_box
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

* update with crypto_box new API

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Alex Xiong <alex.xiong.tech@gmail.com>
sveitser added a commit that referenced this pull request Nov 29, 2022
Update crypto box to prevent dependency resolution conflicts.

See: #107

- Add a release branch, since this diverges from main.
- Build pushes and PRs to release branch.
@sveitser sveitser mentioned this pull request Nov 29, 2022
sveitser added a commit that referenced this pull request Nov 29, 2022
Update crypto box to prevent dependency resolution conflicts.

See: #107

- Add a release branch, since this diverges from main.
- Build pushes and PRs to release branch.
alxiong added a commit that referenced this pull request Nov 30, 2022
* Build release branches and PRs to release branches

* Update crypto_box requirement from 0.7.1 to 0.8.1 (#107)

* Update crypto_box requirement from 0.7.1 to 0.8.1

Updates the requirements on [crypto_box](https://github.com/RustCrypto/nacl-compat) to permit the latest version.
- [Release notes](https://github.com/RustCrypto/nacl-compat/releases)
- [Commits](RustCrypto/nacl-compat@crypto_box-v0.7.1...crypto_box-v0.8.1)

---
updated-dependencies:
- dependency-name: crypto_box
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

* update with crypto_box new API

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Alex Xiong <alex.xiong.tech@gmail.com>

* Fix clippy errors

* Release 0.1.3

Update crypto box to prevent dependency resolution conflicts.

See: #107

- Add a release branch, since this diverges from main.
- Build pushes and PRs to release branch.

* bump zeroize and use nix flake

* fix clippy error

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Alex Xiong <alex.xiong.tech@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file rust Rust or rust toolchains related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants