Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gadgets for comparing to constant #117

Merged
merged 3 commits into from
Aug 31, 2022
Merged

Gadgets for comparing to constant #117

merged 3 commits into from
Aug 31, 2022

Conversation

mrain
Copy link
Contributor

@mrain mrain commented Aug 30, 2022

Description

closes: #104
Some unfinished work for #96 and #81

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (main)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

@mrain mrain requested a review from alxiong August 30, 2022 21:04
@mrain mrain force-pushed the chengyu/cmp_constant branch from a207c42 to 8dec7f7 Compare August 30, 2022 21:06
@mrain mrain changed the title Chengyu/cmp constant Gadgets for comparing to constant Aug 30, 2022
@mrain mrain requested a review from chancharles92 August 31, 2022 12:51
alxiong
alxiong reviewed Aug 31, 2022
View reviewed changes
Copy link
Contributor

@alxiong alxiong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM, just a small comment for smaller code repetition in test.

relation/src/gadgets/cmp.rs Outdated Show resolved Hide resolved
@mrain mrain requested a review from alxiong August 31, 2022 14:57
chancharles92
chancharles92 reviewed Aug 31, 2022
View reviewed changes
Copy link
Contributor

@chancharles92 chancharles92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM

relation/src/gadgets/cmp.rs Outdated Show resolved Hide resolved
relation/src/gadgets/cmp.rs Outdated Show resolved Hide resolved
@mrain mrain enabled auto-merge (squash) August 31, 2022 21:41
@mrain mrain disabled auto-merge August 31, 2022 21:41
@mrain mrain merged commit 851c937 into main Aug 31, 2022
@mrain mrain deleted the chengyu/cmp_constant branch August 31, 2022 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chancharles92 chancharles92 chancharles92 approved these changes

@alxiong alxiong Awaiting requested review from alxiong alxiong is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Constraint] compare to constant gate
3 participants
@mrain @chancharles92 @alxiong